Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes from Chromium, redux, part 1. #87

Merged
merged 4 commits into from
Mar 24, 2015

Conversation

davidben
Copy link

In the interest of not sitting on all of these until I find time to clean them up, here's the first half of #50. They're unchanged from the original PR except that FALLBACK_SCSV has been cleaned up. It now implements the client half as well and uses it to implement a pair of tests. I removed the configuration option for the server half; I figure that's more of a "patch in a bug" sort of change that we ought to keep carrying in our own tree. (Though if you want it, I'm happy to stop carrying them!)

Adapted from a Chromium patch, with tests and client-side portions
added.
SSL 3.0 requires minimal padding. (TLS doesn't require it but accepts it, so
apply uniformly to both.)

From Chromium.
@davidben davidben force-pushed the chromium-patches-1 branch from a1f1dfb to daf2e15 Compare March 24, 2015 05:02
trevp added a commit that referenced this pull request Mar 24, 2015
Various changes from Chromium, redux, part 1.
@trevp trevp merged commit 463e281 into trevp:master Mar 24, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 37.29% when pulling daf2e15 on davidben:chromium-patches-1 into 7acf1fe on trevp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 40.85% when pulling daf2e15 on davidben:chromium-patches-1 into 7acf1fe on trevp:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants